Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add circleci support #1266

Merged
merged 2 commits into from
Jun 26, 2015
Merged

add circleci support #1266

merged 2 commits into from
Jun 26, 2015

Conversation

jbenet
Copy link
Member

@jbenet jbenet commented May 21, 2015

No description provided.

@jbenet jbenet added the status/in-progress In progress label May 21, 2015
@jbenet jbenet force-pushed the add-circleci branch 2 times, most recently from 05b8506 to 1fcde90 Compare May 21, 2015 04:55
@jbenet jbenet force-pushed the add-circleci branch 4 times, most recently from b4aea8b to c3f6369 Compare May 30, 2015 05:14
@jbenet
Copy link
Member Author

jbenet commented May 30, 2015

Fixed IPv6 suppor on Circle-CI. needed:

dependencies:
  pre:
    # setup ipv6
    - sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=0 net.ipv6.conf.default.disable_ipv6=0 net.ipv6.conf.all.disable_ipv6=0

@jbenet
Copy link
Member Author

jbenet commented May 30, 2015

Interesting failure: https://circleci.com/gh/ipfs/go-ipfs/18

> diff -u expected_daemon actual_daemon
--- expected_daemon 2015-05-30 05:19:38.485674000 +0000
+++ actual_daemon   2015-05-30 05:19:37.753674000 +0000
@@ -1,5 +1,5 @@
 Initializing daemon...
-initializing ipfs node at /home/ubuntu/go-ipfs/test/sharness/trash directory.t0060-daemon.sh/.ipfs
+initializing ipfs node at /home/ubuntu/.go_project/src/github.com/ipfs/go-ipfs/test/sharness/trash directory.t0060-daemon.sh/.ipfs
 generating 2048-bit RSA keypair...done
 peer identity: QmRwRKHMhXdBabdc7tv9TvDbznQggkTrW5a4GXGzmxGXmG
 to get started, enter:

Looks like $(pwd) isn't cutting it. weird links? cc @chriscool @cryptix

@whyrusleeping
Copy link
Member

circleCI needs to run tests with the nofuse tags set

@jbenet
Copy link
Member Author

jbenet commented Jun 1, 2015

circleCI needs to run tests with the nofuse tags set

i think that's a different problem, no?

i set the TRAVIS env var. maybe also need another.

@jbenet
Copy link
Member Author

jbenet commented Jun 1, 2015

circleCI needs to run tests with the nofuse tags set

is that the bug here though? seems different

@chriscool
Copy link
Contributor

Yeah it look like a path or Iink related bug. I will have a look on Saturday or Sunday.

@jbenet
Copy link
Member Author

jbenet commented Jun 8, 2015

@chriscool any leads?

maybe a symlink issue? ipfs thinks it is in a different path than the sharness tests. odd because ipfs init is called by the same shell.

> diff -u expected_daemon actual_daemon
--- expected_daemon 2015-05-30 05:19:38.485674000 +0000
+++ actual_daemon   2015-05-30 05:19:37.753674000 +0000
@@ -1,5 +1,5 @@
 Initializing daemon...
-initializing ipfs node at /home/ubuntu/go-ipfs/test/sharness/trash directory.t0060-daemon.sh/.ipfs
+initializing ipfs node at /home/ubuntu/.go_project/src/github.com/ipfs/go-ipfs/test/sharness/trash directory.t0060-daemon.sh/.ipfs
 generating 2048-bit RSA keypair...done
 peer identity: QmRwRKHMhXdBabdc7tv9TvDbznQggkTrW5a4GXGzmxGXmG
 to get started, enter:

@jbenet jbenet mentioned this pull request Jun 16, 2015
55 tasks
@whyrusleeping whyrusleeping mentioned this pull request Jun 23, 2015
34 tasks
@GitCop
Copy link

GitCop commented Jun 25, 2015

There were the following issues with your Pull Request

  • Commit: c3f6369
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

@chriscool
Copy link
Contributor

Exporting IPFS_PATH is enough to make the CircleCI sharness tests pass.

@chriscool chriscool mentioned this pull request Jun 25, 2015
@jbenet
Copy link
Member Author

jbenet commented Jun 25, 2015

@chriscool great stuff!

@chriscool
Copy link
Contributor

@jbenet is there anything else I can do about this?
Your commit is missing a License and a Signed-off-by trailer but I think it's better if you add them yourself.

@chriscool
Copy link
Contributor

One Travis test failed with "Error: context deadline exceeded":

expecting success: 
    export IPFS_PATH="$IPTB_ROOT/3" &&
    NODE2_ID=`iptb get id 2` &&
    ipfs cat /ipns/$NODE2_ID > output
Error: context deadline exceeded
not ok 5 - cat that entry on a third node
#   
#       export IPFS_PATH="$IPTB_ROOT/3" &&
#       NODE2_ID=`iptb get id 2` &&
#       ipfs cat /ipns/$NODE2_ID > output
#   

@jbenet
Copy link
Member Author

jbenet commented Jun 26, 2015

@chriscool this is great, thanks. Will fix, force-push and merge

chriscool and others added 2 commits June 26, 2015 02:07
IPFS_PATH should really be exported to make sure it is
available to the ipfs binary.

It looks like sharness tests fail otherwise on CircleCi.

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>
jbenet added a commit that referenced this pull request Jun 26, 2015
@jbenet jbenet merged commit 51aeb12 into master Jun 26, 2015
@jbenet jbenet removed the status/in-progress In progress label Jun 26, 2015
@jbenet jbenet deleted the add-circleci branch June 26, 2015 09:26
@jbenet
Copy link
Member Author

jbenet commented Jun 26, 2015

circleci support merged! thanks very much @chriscool \o/

@whyrusleeping whyrusleeping mentioned this pull request Jul 1, 2015
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants